[IMPROVE] Replace personalAccessTokens publication by REST #15644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
reviewed
Oct 24, 2019
| @@ -3,6 +3,7 @@ import { Meteor } from 'meteor/meteor'; | |||
| import { hasPermission } from '../../../../app/authorization'; | |||
| import { Users } from '../../../../app/models'; | |||
|
|
|||
| console.warn('The publication "personalAccessTokens" is deprecated and will be removed after version v3.0.0'); | |||
There was a problem hiding this comment.
Can we move those warnings to inside the publication, so then we know when it has being used, today ir raises all those warnings on server startup what is not meaningful to understand if someplace is still using it.
There was a problem hiding this comment.
@rodrigok That was a suggestion from @ggazzo and @sampaiodiego.
There was a problem hiding this comment.
right.. this way (outside the publication) there is more chance of and admin to see the warning.
I would not mind adding to both places though. wdyt?
sampaiodiego
approved these changes
Oct 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.